[llvm] r221471 - Try to appease MSVC buildbots after r221466.

[Sean Callanan]

The reference is not guaranteed to be a Value*, for LLDB, metadata can refer back to clang::NamedDecl*s.
This is breaking LLDB buildbots because printf() no longer works in LLDB:
	http://lab.llvm.org:8011/builders/lldb-x86_64-freebsd/builds/2513 <http://lab.llvm.org:8011/builders/lldb-x86_64-freebsd/builds/2513> (picked up clang 221471) is broken
	http://lab.llvm.org:8011/builders/lldb-x86_64-freebsd/builds/2512 <http://lab.llvm.org:8011/builders/lldb-x86_64-freebsd/builds/2512> (picked up clang 221467) is pretty clean
We need to find a better way to solve this.  In the meantime I am going to see if reverting this change makes LLDB happy again.

Sean

> On Nov 6, 2014, at 11:00 AM, Frederic Riss <friss at apple.com> wrote:
> 
> Author: friss
> Date: Thu Nov  6 13:00:47 2014
> New Revision: 221471
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=221471&view=rev
> Log:
> Try to appease MSVC buildbots after r221466.
> 
> Modified:
>    llvm/trunk/lib/IR/DIBuilder.cpp
> 
> Modified: llvm/trunk/lib/IR/DIBuilder.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/DIBuilder.cpp?rev=221471&r1=221470&r2=221471&view=diff
> ==============================================================================
> --- llvm/trunk/lib/IR/DIBuilder.cpp (original)
> +++ llvm/trunk/lib/IR/DIBuilder.cpp Thu Nov  6 13:00:47 2014
> @@ -194,7 +194,7 @@ DIImportedEntity DIBuilder::createImport
>                                                       unsigned Line, StringRef Name) {
>   // Make sure to use the unique identifier based metadata reference for
>   // types that have one.
> -  Value *V = Decl.isType() ? DIType(Decl).getRef() : Decl;
> +  Value *V = Decl.isType() ? static_cast<Value*>(DIType(Decl).getRef()) : Decl;
>   return ::createImportedModule(VMContext, dwarf::DW_TAG_imported_declaration,
>                                 Context, V, Line, Name,
>                                 AllImportedModules);
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141106/0b2a0e05/attachment.html>