[PATCH] [X86] Fix pattern match for 32-to-64-bit zext in the presence of AssertSext
Nadav Rotem
nrotem at apple.com
Thu Nov 6 12:23:50 PST 2014
Can you please add a check line for ‘ret’ ? I want to make sure that the check line does not mix with code from the following test. With that the code LGTM.
> On Nov 6, 2014, at 1:36 AM, Michael Kuperstein <michael.m.kuperstein at intel.com> wrote:
>
> Shortened the testcase and changed the name.
> I think checking for a mov with the specific registers is the right thing to do, as the registers are determined by the ABI - the function parameter must come in ecx, and the ret value must go to eax.
> Nadav, if you think that's too specific, let me know.
>
> Michael
>
> http://reviews.llvm.org/D6128
>
> Files:
> lib/Target/X86/X86InstrCompiler.td
> test/CodeGen/X86/TruncAssertZext.ll
> <D6128.15845.patch>
More information about the llvm-commits
mailing list