[llvm] r221221 - Use findProgramByName.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Nov 6 05:15:12 PST 2014


ping. We should change the code or the coding style, but not leave
them like this.

On 3 November 2014 23:51, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> On 3 November 2014 20:29, Michael J. Spencer <bigcheesegs at gmail.com> wrote:
>> Author: mspencer
>> Date: Mon Nov  3 19:29:59 2014
>> New Revision: 221221
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=221221&view=rev
>> Log:
>> Use findProgramByName.
>>
>> Modified:
>>     llvm/trunk/lib/Support/GraphWriter.cpp
>>     llvm/trunk/tools/bugpoint/OptimizerDriver.cpp
>>     llvm/trunk/tools/bugpoint/ToolRunner.cpp
>>     llvm/trunk/utils/not/not.cpp
>>
>> Modified: llvm/trunk/lib/Support/GraphWriter.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/GraphWriter.cpp?rev=221221&r1=221220&r2=221221&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Support/GraphWriter.cpp (original)
>> +++ llvm/trunk/lib/Support/GraphWriter.cpp Mon Nov  3 19:29:59 2014
>> @@ -105,9 +105,11 @@ struct GraphSession {
>>      SmallVector<StringRef, 8> parts;
>>      Names.split(parts, "|");
>>      for (auto Name : parts) {
>> -      ProgramPath = sys::FindProgramByName(Name);
>> -      if (!ProgramPath.empty())
>> +      auto P = sys::findProgramByName(Name);
>
> I don't think the style guide supports using auto in cases like this.
>
> Cheers,
> Rafael




More information about the llvm-commits mailing list