[lld] r221426 - [ELF] Use std::find_if instead

[Shankar Easwaram]

Yes.



> On Nov 5, 2014, at 23:39, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> 
>> On 5 November 2014 21:03, Shankar Easwaran <shankarke at gmail.com> wrote:
>> Author: shankare
>> Date: Wed Nov  5 20:03:35 2014
>> New Revision: 221426
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=221426&view=rev
>> Log:
>> [ELF] Use std::find_if instead
>> 
>> Modified:
>>    lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h
>>    lld/trunk/lib/ReaderWriter/ELF/SegmentChunks.h
>> 
>> Modified: lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h
>> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h?rev=221426&r1=221425&r2=221426&view=diff
>> ==============================================================================
>> --- lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h (original)
>> +++ lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h Wed Nov  5 20:03:35 2014
>> @@ -630,8 +630,6 @@ DefaultLayout<ELFT>::mergeSimilarSection
>> template <class ELFT> void DefaultLayout<ELFT>::assignSectionsToSegments() {
>>   ScopedTask task(getDefaultDomain(), "assignSectionsToSegments");
>>   ELFLinkingContext::OutputMagic outputMagic = _context.getOutputMagic();
>> -    // TODO: Do we want to give a chance for the targetHandlers
>> -    // to sort segments in an arbitrary order?
>>   // sort the sections by their order as defined by the layout
>>   std::stable_sort(_sections.begin(), _sections.end(),
>>                    [](Chunk<ELFT> *A, Chunk<ELFT> *B) {
>> 
> 
> Was removing the TODO supposed to be part of this commit?
> 
> Cheers,
> Rafael