[lld] r221428 - [ELF] Use llvm::Twine
Shankar Easwaran
shankarke at gmail.com
Wed Nov 5 18:03:40 PST 2014
Author: shankare
Date: Wed Nov 5 20:03:40 2014
New Revision: 221428
URL: http://llvm.org/viewvc/llvm-project?rev=221428&view=rev
Log:
[ELF] Use llvm::Twine
Modified:
lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h
Modified: lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h?rev=221428&r1=221427&r2=221428&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h Wed Nov 5 20:03:40 2014
@@ -130,12 +130,8 @@ template <class ELFT> void ExecutableWri
auto endAtomIter = this->_layout.findAbsoluteAtom("end");
auto startEnd = [&](StringRef sym, StringRef sec) -> void {
- // TODO: This looks like a good place to use Twine...
- std::string start("__"), end("__");
- start += sym;
- start += "_start";
- end += sym;
- end += "_end";
+ std::string start = (llvm::Twine("__", sym) + "_start").str();
+ std::string end = (llvm::Twine("__", sym) + "_end").str();
auto s = this->_layout.findAbsoluteAtom(start);
auto e = this->_layout.findAbsoluteAtom(end);
auto section = this->_layout.findOutputSection(sec);
More information about the llvm-commits
mailing list