[PATCH] Fix for nasty LTO issue that's most obvious in ObjectiveC.

Kevin Frei freik at fb.com
Wed Nov 5 15:52:55 PST 2014


Hi abdulras,

The LTO module linker is dropping the 'isExternallyInitialized' attribute from GlobalVariable's as it's copying them into the One Module to Rule Them All. This results in later phases believing that values can be copy-prop'ed or pre-evaluated. The second change is the one that actually fixes the problem, but the first change looks like a similar oversight, so I also changed it to include the attribute.

This bug prevents LTO from being usable by the Facebook iOS app.

http://reviews.llvm.org/D6145

Files:
  lib/Linker/LinkModules.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6145.15827.patch
Type: text/x-patch
Size: 1086 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141105/2722b3a9/attachment.bin>


More information about the llvm-commits mailing list