[LLVMdev] [PATCH] ARM64 GHC Calling Convention

[Tim Northover]

Hi Luke,

I've moved the e-mails to the llvm-commits list, which is where
patches are usually discussed.

On 4 November 2014 23:55, Luke Iannini <lukexipd at gmail.com> wrote:
> This patch adds an ARM64 calling convention for GHC to round out the
> existing set.

Thanks for working in this! It's one of the things I'd have loved to
get working in the very first AArch64 commit, but I never really knew
enough about GHC internals to do it quickly.

On the patch itself, it would be good to have some tests (in
test/CodeGen/AArch64) with some typical, trivial GHC-like functions,
to make sure everything is working as intended. Most of the changes
look reasonably sane, though only running with GHC will tell for sure.

I did have one question about the change to getThisReturnPreservedMask
though. Does GHC actually use that? I seem to remember it's a bit of
an edge-case C++ issue. If not, it would probably be best to just
assert that the calling-convention *isn't* GHC rather than giving
people reading the code something else to think about that doesn't
really matter.

Cheers.

Tim.