[PATCH] [x86 fast-isel] Materialize allocas with the correct-sized lea for ILP32

Jan Voung jvoung at chromium.org
Wed Nov 5 11:16:34 PST 2014


================
Comment at: test/CodeGen/X86/x32-alloca.ll:2
@@ +1,3 @@
+; RUN: llc < %s -mtriple=x86_64-linux-gnux32 -fast-isel | FileCheck %s
+; RUN: llc < %s -mtriple=x86_64-nacl -fast-isel | FileCheck %s
+
----------------
Add "-fast-isel-abort" to make sure it's actually using fast-isel for this codegen?

A bunch of the other fast-isel tests have a "fast-isel-" prefix for the filename. Perhaps it would be good to stick with that.

I couldn't find any existing test for this for non ILP32 x86-64 code, so might as well test the non-ILP32 x86-64 code path too. Maybe the test can be merged into fast-isel-x86-64.ll (but only have a check-prefix of this case for x32 for now)?


================
Comment at: test/CodeGen/X86/x32-alloca.ll:6
@@ +5,3 @@
+
+define void @bar(i32* %arg) {
+  ret void
----------------
could probably just make bar a "declare" and not have to codegen it

http://reviews.llvm.org/D6136






More information about the llvm-commits mailing list