[PATCH] [mips][microMIPS] Mark symbols as microMIPS if necessary
Sasa Stankovic
Sasa.Stankovic at imgtec.com
Wed Nov 5 04:13:51 PST 2014
LGTM, with two changes.
================
Comment at: lib/Target/Mips/MCTargetDesc/MipsELFStreamer.cpp:39
@@ +38,3 @@
+ for (auto Label : Labels) {
+ MCSymbolData &Data = getOrCreateSymbolData(Label);
+ // The "other" values are stored in the last 6 bits of the second byte
----------------
Add '.' at the end of sentence.
================
Comment at: lib/Target/Mips/MCTargetDesc/MipsELFStreamer.h:51
@@ -48,1 +50,3 @@
+ /// Overriding this function allows us to record all labels that should be
+ /// marked as microMIPS. based on this data marking is done in
----------------
"based" should start with uppercase.
http://reviews.llvm.org/D6039
More information about the llvm-commits
mailing list