[PATCH] [ARM] Fix ARM triple parsing.

[Eric Christopher]

On Tue Nov 04 2014 at 5:26:00 AM Renato Golin <renato.golin at linaro.org>
wrote:

> Eric,
>
> From my point of view, the issue this solves is that now you can say
> "-triple armvelocipede" and it'll work. That's far from ideal.
>
>
*shrug* You'll get a generic arm processor. I agree that it's not ideal.


> I'd prefer to have a proper parser to get arch+cpu+features from
> triple/march/mcpu/mfpu/mtune options, but that'll require the TargetInfo
> parser, which will take a while. For now, this patch would at least cover
> the bogus cases in ARM.
>
>
If it's a problem you're running into sure.


> I agree some tests are in order, but I believe we already have some.
>
>
It will need negative tests for certain. I'd prefer to get all of them
squirreled away.

-eric


> Gabor,
>
> Have you checked for current tests on that? Are they complete? Even if
> they are, we should have at least a few negative tests ("RUN: not" lines)
> to make sure we don't accept the things we say we won't.
>
> cheers,
> --renato
>
> http://reviews.llvm.org/D6058
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141104/2f56cddb/attachment.html>