One comment inline. ================ Comment at: lib/IR/Module.cpp:472 @@ +471,3 @@ +void Module::setPICLevel(PICLevel::Level PL) { + addModuleFlag(ModFlagBehavior::Error, "flag_pic", PL); +} ---------------- One bike shed: "PIC Level" perhaps? since it's not just -fpic, but also -fPIC? http://reviews.llvm.org/D5882