[PATCH] [ARM] Fix ARM triple parsing.

Renato Golin renato.golin at linaro.org
Tue Nov 4 08:49:43 PST 2014


Hi Gabor,

You need to create two reviews, one for each, and cross reference each other (in the text, writing DNNNN will link automatically).

However, LLVM changes normally have to be self-contained, so you should have tests in the LLVM side as well. I believe using llc for that should work.

When it gets to commit, you should commit the LLVM part first, and aim for it to pass even without Clang being updated, since not everyone uses clang. Clang commits can depend on LLVM ones, and that's why you need to commit to LLVM first.

cheers,
--renato

http://reviews.llvm.org/D6058






More information about the llvm-commits mailing list