[PATCH] Enable running Ubsan tests on FreeBSD

Viktor Kutuzov vkutuzov at accesssoftek.com
Tue Nov 4 03:23:29 PST 2014


================
Comment at: test/ubsan/lit.common.cfg:50
@@ -49,3 +49,3 @@
 # UndefinedBehaviorSanitizer tests are currently supported on
-# Linux and Darwin only.
-if config.host_os not in ['Linux', 'Darwin']:
+# Linux, Darwin and FreeBSD only.
+if config.host_os not in ['Linux', 'Darwin', 'FreeBSD']:
----------------
samsonov wrote:
> emaste wrote:
> > This comment is identical to the test that immediately follows so seems redundant.
> > 
> > Perhaps:
> > ```
> > # Check that the host supports UndefinedBehaviorSanitizer
> > if config.host_os not in ...
> > ```
> Or just delete this comment, the statement seems simple enough.
The comment itself looks to be useful as it refers to UndefinedBehaviorSanitizer tests explicitly while the code does not, but I agree that there's little sense in duplicating the list of supported platforms. I will follow the Ed's proposal, if there are no objections. Thanks.

http://reviews.llvm.org/D6089






More information about the llvm-commits mailing list