[llvm] r221244 - #include <winbase.h> is not enough for Visual C++ 2013, it errors:

Yaron Keren yaron.keren at gmail.com
Mon Nov 3 23:53:30 PST 2014


Author: yrnkrn
Date: Tue Nov  4 01:53:30 2014
New Revision: 221244

URL: http://llvm.org/viewvc/llvm-project?rev=221244&view=rev
Log:
#include <winbase.h> is not enough for Visual C++ 2013, it errors:

1>C:\Program Files (x86)\Windows Kits\8.1\Include\um\minwinbase.h(46):
error C2146: syntax error : missing ';' before identifier 'nLength'
1>C:\Program Files (x86)\Windows Kits\8.1\Include\um\minwinbase.h(46):
error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
...

including <windows.h> is actually required.


Modified:
    llvm/trunk/lib/Support/Windows/Threading.inc

Modified: llvm/trunk/lib/Support/Windows/Threading.inc
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Windows/Threading.inc?rev=221244&r1=221243&r2=221244&view=diff
==============================================================================
--- llvm/trunk/lib/Support/Windows/Threading.inc (original)
+++ llvm/trunk/lib/Support/Windows/Threading.inc Tue Nov  4 01:53:30 2014
@@ -1,4 +1,4 @@
-#include <winbase.h>
+ #include <windows.h>
 
 #ifdef MemoryFence
 // WinNT.h seems to define a MemoryFence macro.





More information about the llvm-commits mailing list