[PATCH] [PATCH] FastISel fixes with FeatureVSX enabled

Eric Christopher echristo at gmail.com
Fri Oct 31 17:11:33 PDT 2014


>>! In D5362#35, @wschmidt wrote:
> I've been thinking about this a bit more, and I'm not very happy with a solution that changes the general FastISel machinery, given that it's intended to be temporary.  I think seurer is making pretty good progress on the real solution for VSX in FastISel, so it might be best to suck it up and wait for that to be completed.  Thoughts?
> 

This is definitely my preference here. As a temporary solution I'm absolutely ok with checking if VSX is enabled and just disabling fastisel.

> BTW, from a note he sent me this morning I have a feeling that FastISel may be ignoring AddedComplexity in the pattern selection code.  The VSX pattern should be preferred over the other when available, but the non-VSX pattern code is being generated first, which doesn't give the VSX pattern a chance.  Eric, is this possible?

I'm fairly certain we don't pay attention to AddedComplexity in fast isel. One solution would be to change the order of those patterns in the file I think. At least might be worth a try.

-eric

http://reviews.llvm.org/D5362






More information about the llvm-commits mailing list