[PATCH] [mips64] Add support for MCJIT for MIPS64

Lang Hames lhames at gmail.com
Fri Oct 31 14:40:13 PDT 2014


Hi Vladimir.

Sorry for the delayed response on this, and thanks for working on this.

I think this patch will need to be significantly re-worked before it can go in to the mainline. As it is currently written, it adds a lot of target specific fields and arguments to the RuntimeDyldELF class. We're hoping to reverse the trend of every architecture being lumped in to the one RuntimeDyldELF class. We want to implement future targets (and refactor existing targets) into target specific base classes. You can check out RuntimeDyldMachO and its subclasses for an idea of where we want to go. Some time in the next couple of weeks I'm hoping to break the X86 target out of RuntimeDyldELF and in to its own class (probably RuntimeDyldELFX86). When that happens, it might be useful for you to use as a template for a RuntimeDyldELFMips class.

A couple of specific questions: Why do you need the SymbolName field in RelocationEntry, and the IsLocal member in RelocationValueRef? We want to avoid bloating these classes, since they're shared by all targets. I may be able to suggest other places to attach/handle this information. If it really is required in those structs, I can try to plan my refactor so that RuntimeDyldMips can define its own versions.

Cheers,
Lang.

http://reviews.llvm.org/D5913






More information about the llvm-commits mailing list