[PATCH] [AArch64] Check Dest Resgister Liveness in CondOpt pass
Sergey Dmitrouk
sdmitrouk at accesssoftek.com
Fri Oct 31 04:11:59 PDT 2014
Hi,
Somehow from instruction reference and comments I mistakenly assumed that
such instructions won't occur with liveout destinations, but now I see it
should be checked. I tried to make a test-case for a couple hours, but
had no luck here.
Thanks for catching this!
Regards,
Sergey
================
Comment at: lib/Target/AArch64/AArch64ConditionOptimizer.cpp:130
@@ -128,1 +129,3 @@
+ AU.addRequired<LiveIntervals>();
+ AU.addPreserved<LiveIntervals>();
MachineFunctionPass::getAnalysisUsage(AU);
----------------
There is `INITIALIZE_PASS_BEGIN`...`INITIALIZE_PASS_END` above (not full context, by the way), `LiveIntervals` should be added there as well or just drop lines from `namespace llvm {` to `INITIALIZE_PASS_END` (might be preferred).
http://reviews.llvm.org/D6048
More information about the llvm-commits
mailing list