[PATCH] Removing the static initializer in ManagedStatic.cpp by using llvm_call_once to initialize the ManagedStatic mutex.
Reid Kleckner
rnk at google.com
Thu Oct 30 13:32:47 PDT 2014
n Thu, Oct 30, 2014 at 1:29 PM, Chris Bieneman <beanz at apple.com> wrote:
> While I recognize that Chandler's point is probably right that we should
> use the Windows API (caveat that we're ok with dropping running on XP as
> Reid pointed out).
>
> Would it be reasonable for me to land the hand-rolled double checked
> solution instead, and have someone else (preferably someone more skilled
> with Windows) implement the Windows API based solution later?
>
Let's do that. It's a strict improvement over the single check static local
initializer we have currently.
In a week or so after the XP RFC has baked we can go back and do this
better.
http://reviews.llvm.org/D5922
More information about the llvm-commits
mailing list