[PATCH] [MSan] [MIPS] Adding support for MIPS64

Evgeniy Stepanov eugenis at google.com
Wed Oct 29 17:45:59 PDT 2014


I'm OK with this change, but please wait for a comment from Kostya.

> I just wanted to ask if I should submit those patches for review, or wait till this one is merged.

Better send them early.

================
Comment at: lib/msan/msan.h:35
@@ -28,1 +34,3 @@
+  ((uptr)mem >= 0xa000000000ULL && (uptr)mem <= 0xc000000000ULL)
+#else
 #define MEM_TO_SHADOW(mem)       (((uptr)mem) & ~0x400000000000ULL)
----------------
Please change this to #elif defined(__x86_64__) and an #error if neither is defined.
The same in msan_allocator.cc and other similar cases.

http://reviews.llvm.org/D5906






More information about the llvm-commits mailing list