[llvm] r220840 - macho-symbolized-disassembly.test: Don't check C++ demangler unconditionally.

[Kevin Enderby]

Hello NAKAMURA Takumi,

Thanks for the fix.  Nick and I talked about this before I committed the patch and we thought things would just work as the Mach-O tests were some how not run in windows, at least that was his experience.  We’ll see about fixing this right if we need to have these tests.

Thanks,
Kev

On Oct 29, 2014, at 1:08 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:

> Author: chapuni
> Date: Wed Oct 29 03:08:21 2014
> New Revision: 220840
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=220840&view=rev
> Log:
> macho-symbolized-disassembly.test: Don't check C++ demangler unconditionally.
> 
> For example, MS PSDK is not expected to have <cxxabi.h>.
> You should introduce the new feature in lit.cfg corresponding to HAVE_CXXABI_H if you would like to test demangler.
> 
> Modified:
>    llvm/trunk/test/tools/llvm-objdump/X86/macho-symbolized-disassembly.test
> 
> Modified: llvm/trunk/test/tools/llvm-objdump/X86/macho-symbolized-disassembly.test
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/X86/macho-symbolized-disassembly.test?rev=220840&r1=220839&r2=220840&view=diff
> ==============================================================================
> --- llvm/trunk/test/tools/llvm-objdump/X86/macho-symbolized-disassembly.test (original)
> +++ llvm/trunk/test/tools/llvm-objdump/X86/macho-symbolized-disassembly.test Wed Oct 29 03:08:21 2014
> @@ -25,4 +25,7 @@ ObjC-EXE: 0000000100000f1b	movq	0x10e(%r
> ObjC-EXE: 0000000100000f25	callq	0x100000f4a             ## Objc message: +[NSDate date]
> ObjC-EXE: 0000000100000f33	callq	0x100000f44             ## symbol stub for: _NSLog
> 
> -CXX-EXE: 00000001000014cb	callq	__ZNSt3__116__pad_and_outputIcNS_11char_traitsIcEEEENS_19ostreambuf_iteratorIT_T0_EES6_PKS4_S8_S8_RNS_8ios_baseES4_ ## std::__1::ostreambuf_iterator<char, std::__1::char_traits<char> > std::__1::__pad_and_output<char, std::__1::char_traits<char> >(std::__1::ostreambuf_iterator<char, std::__1::char_traits<char> >, char const*, char const*, char const*, std::__1::ios_base&, char)
> +CXX-EXE: 00000001000014cb	callq	__ZNSt3__116__pad_and_outputIcNS_11char_traitsIcEEEENS_19ostreambuf_iteratorIT_T0_EES6_PKS4_S8_S8_RNS_8ios_baseES4_
> +
> +// FIXME: Demangler depends on host's <cxxabi.h>.
> +// std::__1::ostreambuf_iterator<char, std::__1::char_traits<char> > std::__1::__pad_and_output<char, std::__1::char_traits<char> >(std::__1::ostreambuf_iterator<char, std::__1::char_traits<char> >, char const*, char const*, char const*, std::__1::ios_base&, char)
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits