[PATCH] EXPORTED_SYMBOL_FILE using mingw and cmake

Wed Oct 29 00:52:48 PDT 2014

That wasn ‘t my intent. I created a new version of the patch, I just didn’t know how to replace the old one (I found out by now).

--
Johannes S. Mueller-Roemer, MSc
Wiss. Mitarbeiter - Interactive Engineering Technologies (IET)

Fraunhofer-Institut für Graphische Datenverarbeitung IGD
Fraunhoferstr. 5  |  64283 Darmstadt  |  Germany
Tel +49 6151 155-606  |  Fax +49 6151 155-139
johannes.mueller-roemer at igd.fraunhofer.de  |  www.igd.fraunhofer.de

From: Owen Anderson [mailto:resistor at mac.com]
Sent: Wednesday, October 29, 2014 07:18
To: reviews+D5476+public+b1ec86e0fdfb2724 at reviews.llvm.org
Cc: Mueller-Roemer, Johannes Sebastian; llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] EXPORTED_SYMBOL_FILE using mingw and cmake

On Oct 28, 2014, at 3:39 PM, Chris Bieneman <beanz at apple.com<mailto:beanz at apple.com>> wrote:

You have two options. Either you can adapt the patch based on the feedback I've provided, or you can get someone else in the community to review and accept the patch. I admit I am not the most qualified person to review this patch.

Making end-runs around the review process by seeking another reviewer is frowned upon.  You are welcome to seek additional opinions and try to form a consensus or break a deadlock, but you should not simply disregard a reviewer’s comments.

—Owen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141029/51c7c954/attachment.html>