[PATCH] [lsan] [mips] adding support of lsan for mips64/mips64el arch
Alexey Samsonov
vonosmas at gmail.com
Tue Oct 28 09:29:53 PDT 2014
================
Comment at: lib/lsan/lsan_common.cc:147
@@ -146,1 +146,3 @@
return ((p >> 47) == 0);
+#elif defined(__mipe64)
+ return ((p >> 40) == 0);
----------------
typo: shouldn't this be __mips64?
================
Comment at: lib/sanitizer_common/sanitizer_printf.cc:118
@@ +117,3 @@
+ result += AppendUnsigned(buff, buff_end, ptr_value, 16,
+ (SANITIZER_WORDSIZE == 64) ? 10 : 8, true);
+#else
----------------
Please introduce a named constant for 10/12 instead with a comment.
http://reviews.llvm.org/D5616
More information about the llvm-commits
mailing list