[llvm] r220772 - LoopRerollPass.cpp: Use range-based loop. NFC.

[NAKAMURA Takumi]

2014-10-28 20:54 GMT+09:00 NAKAMURA Takumi <geek4civic at gmail.com>:
> Author: chapuni
> Date: Tue Oct 28 06:54:05 2014
> New Revision: 220772
>
> URL: http://llvm.org/viewvc/llvm-project?rev=220772&view=rev
> Log:
> LoopRerollPass.cpp: Use range-based loop. NFC.
>
> Modified:
>     llvm/trunk/lib/Transforms/Scalar/LoopRerollPass.cpp
>
> Modified: llvm/trunk/lib/Transforms/Scalar/LoopRerollPass.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopRerollPass.cpp?rev=220772&r1=220771&r2=220772&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Scalar/LoopRerollPass.cpp (original)
> +++ llvm/trunk/lib/Transforms/Scalar/LoopRerollPass.cpp Tue Oct 28 06:54:05 2014
> @@ -241,10 +241,9 @@ protected:
>
>              PossibleRedSet.insert(PossibleReds[i].getPHI());
>              PossibleRedIdx[PossibleReds[i].getPHI()] = i;
> -            for (SimpleLoopReduction::iterator J = PossibleReds[i].begin(),
> -                 JE = PossibleReds[i].end(); J != JE; ++J) {
> -              PossibleRedSet.insert(*J);
> -              PossibleRedIdx[*J] = i;
> +            for (Instruction *J : PossibleReds[i]) {
> +              PossibleRedSet.insert(J);
> +              PossibleRedIdx[J] = i;
>              }
>            }
>        }
> @@ -659,16 +658,15 @@ bool LoopReroll::ReductionTracker::valid
>         RI != RIE; ++RI) {
>      int i = *RI;
>      int PrevIter = 0, BaseCount = 0, Count = 0;
> -    for (SimpleLoopReduction::iterator J = PossibleReds[i].begin(),
> -         JE = PossibleReds[i].end(); J != JE; ++J) {
> -        // Note that all instructions in the chain must have been found because
> -        // all instructions in the function must have been assigned to some
> -        // iteration.
> -      int Iter = PossibleRedIter[*J];
> +    for (Instruction *J : PossibleReds[i]) {
> +      // Note that all instructions in the chain must have been found because
> +      // all instructions in the function must have been assigned to some
> +      // iteration.
> +      int Iter = PossibleRedIter[J];
>        if (Iter != PrevIter && Iter != PrevIter + 1 &&
>            !PossibleReds[i].getReducedValue()->isAssociative()) {
>          DEBUG(dbgs() << "LRR: Out-of-order non-associative reduction: " <<
> -                        *J << "\n");
> +                        J << "\n");

I wonder, in this DEBUG stuff, did you intend to print the pointer
value of J as hexadecimal (instead of llvm::Instruction)?

>          return false;
>        }