[PATCH] Add Position-independent Code model Module API.

Justin Hibbits jrh29 at alumni.cwru.edu
Mon Oct 27 12:38:07 PDT 2014


I'll upload a new diff this evening.  Thanks!

================
Comment at: test/Linker/module-flags-pic-1-a.ll:1
@@ +1,2 @@
+; RUN: llvm-link %s %p/module-flags-pic-1-b.ll -S -o - | FileCheck
+
----------------
rafael wrote:
> This test has no CHECK line. You also need to pass %s to FileCheck
Oops, wonder how this even passed the test run.

================
Comment at: test/Linker/module-flags-pic-1-b.ll:1
@@ +1,1 @@
+; RUN: true
----------------
rafael wrote:
> Please put this in test/Linker/Inputs. That way you don't need the dummy RUN line.
That definitely will make it cleaner.

================
Comment at: test/Linker/module-flags-pic-2-a.ll:2
@@ +1,3 @@
+; RUN: llvm-link %s %p/module-flags-pic-2-b.ll -S -o - | FileCheck
+; XFAIL: *
+
----------------
rafael wrote:
> Why XFAIL?
This test is intended to fail (test merging two different values for !flag_pic).  Is there a better way to do this?

http://reviews.llvm.org/D5882






More information about the llvm-commits mailing list