[compiler-rt] r220635 - [Sanitizer] Make StackTrace a lightweight reference to array of PCs, and

[Alexey Samsonov]

The patch is fine, thanks for committing it! Sorry for the breakage...

On Mon, Oct 27, 2014 at 9:42 AM, Marshall Clow <mclow.lists at gmail.com>
wrote:

>
> On Oct 27, 2014, at 9:01 AM, Marshall Clow <mclow.lists at gmail.com> wrote:
>
> On Oct 27, 2014, at 8:16 AM, Ismail Pazarbasi <ismail.pazarbasi at gmail.com>
> wrote:
>
> On Sun, Oct 26, 2014 at 4:35 AM, Alexey Samsonov <vonosmas at gmail.com>
> wrote:
>
> Author: samsonov
> Date: Sat Oct 25 22:35:14 2014
> New Revision: 220635
>
> URL: http://llvm.org/viewvc/llvm-project?rev=220635&view=rev
> Log:
> [Sanitizer] Make StackTrace a lightweight reference to array of PCs, and
> introduce a BufferedStackTrace class, which owns this array.
>
> Summary:
> This change splits __sanitizer::StackTrace class into a lightweight
> __sanitizer::StackTrace, which doesn't own array of PCs, and
> BufferedStackTrace,
> which owns it. This would allow us to simplify the interface of StackDepot,
> and eventually merge __sanitizer::StackTrace with __tsan::StackTrace.
>
> Test Plan: regression test suite.
>
> Reviewers: kcc, dvyukov
>
> Reviewed By: dvyukov
>
> Subscribers: llvm-commits
>
> [snip]
>
>
> Hi Alexey,
>
> I have found my Mac build was broken. How does the patch look?
>
>
> I, too, have noticed that the Mac build is broken.
>
> [ 24%]
> /Sources/LLVM/llvm/projects/compiler-rt/lib/asan/asan_mac.cc:302:31: error:
> no matching function for call to 'asan_malloc'
>      (asan_block_context_t*) asan_malloc(sizeof(asan_block_context_t),
> stack);
>                              ^~~~~~~~~~~
> /Sources/LLVM/llvm/projects/compiler-rt/lib/asan/asan_allocator.h:148:7:
> note: candidate function not viable: cannot convert from base class pointer
> '__sanitizer::StackTrace *' to derived class pointer
> '__sanitizer::BufferedStackTrace *' for 2nd argument
> void *asan_malloc(uptr size, BufferedStackTrace *stack);
>      ^
> 1 error generated.
>
>
> I can also confirm that Ismail’s patch fixes the compilation failure.
> I have no idea if the patch is *correct*, but it now compiles.
>
> — Marshall
>
>
>


-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141027/048e80f3/attachment.html>