[PATCH] [CodeGenPrepare.cpp] Feedback on changing logic when to convert select to branch

[James Molloy]

Hi Gerolf,

The concept looks fine to me, there's no real functionality change here. One inline comment though.

James

================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:3069
@@ +3068,3 @@
+                         TLI->isPredictableSelectExpensive() ||
+                         isFormingBranchFromSelectProfitable;
+  if (!ConvertToBranch)
----------------
Don't you want "isFormingBranchFromSelectProfitable(SI)" here?

http://reviews.llvm.org/D5998