[PATCH] [MSan] [MIPS] Adding support for MIPS64

Mohit Bhakkad mohit.bhakkad at imgtec.com
Mon Oct 27 03:50:39 PDT 2014


================
Comment at: lib/msan/msan_linux.cc:38
@@ -37,1 +37,3 @@
 
+#if defined(__mips64)
+static const uptr kMemBeg     = 0xe000000000;
----------------
https://code.google.com/p/android/issues/detail?id=75904 suggests that `__mips64` is prevalent than `__mips64__`

================
Comment at: lib/sanitizer_common/sanitizer_allocator.h:475
@@ +474,3 @@
+  // to have kRegionSize >= 2^32
+  COMPILER_CHECK((kRegionSize) >= (1ULL << (40 / 2)));
+#else
----------------
kcc wrote:
> Did you already verify that this actually works?
> For a 40-bit address space you may need to use SanitizerAllocator32 instead. 
Yes, I have verified using both SanitizerAllocator32 and SanitizerAllocator64, which are giving same results. As SizeClassAllocator64 is more efficient, so we are using that.

http://reviews.llvm.org/D5906






More information about the llvm-commits mailing list