[PATCH] Adding llvm-shlib to CMake build system with a few new bells and whistles
Reid Kleckner
rnk at google.com
Thu Oct 23 09:39:22 PDT 2014
lgtm
I'm sure the awk is broken on some platforms, but this is a good start and we can let people try it and fix it as needed.
================
Comment at: tools/llvm-shlib/CMakeLists.txt:1
@@ +1,2 @@
+if(NOT DEFINED LLVM_DYLIB_COMPONENTS)
+ set(LLVM_LINK_COMPONENTS
----------------
Can you add a short comment explaining what this library is? It's not as readily apparent as the other tools.
================
Comment at: tools/llvm-shlib/CMakeLists.txt:67
@@ +66,3 @@
+ VERBATIM )
+ endforeach (lib ${LLVM_LINK_COMPONENTS})
+
----------------
Our CMake generally doesn't repeat the contents of the 'if' and 'foreach' clauses. This one doesn't match, so I'd nuke it and the others.
http://reviews.llvm.org/D5890
More information about the llvm-commits
mailing list