[PATCH] [Tsan] Add support for FreeBSD memory layout

Dmitry Vyukov dvyukov at google.com
Thu Oct 23 01:41:48 PDT 2014


Do you essentially want to support non-pie binaries where something is mapped in the first 64GB? Is it the only difference with the current linux mapping?
If it's the only difference, then it's time for me to implement non-pie support finally.

Add me to tsan reviews, I am the author of tsan.

================
Comment at: lib/tsan/rtl/tsan_platform.h:50
@@ +49,3 @@
+C++ FreeBSD memory layout:
+0000 0000 0000 - 0000 00ff ffff: -
+0000 0100 0000 - 000f ffff ffff: executable, modules and service heap
----------------
please use the same format as entries above -- the second address is exclusive, that is:
0000 0000 0000 - 0000 0100 0000

================
Comment at: lib/tsan/rtl/tsan_platform.h:58
@@ +57,3 @@
+3000 0000 0000 - 5fff ffff ffff: -
+3000 0000 0000 - 3fff ffff ffff: low metainfo (memory blocks and sync objects)
+4000 0000 0000 - 4fff ffff ffff: high metainfo (memory blocks and sync objects)
----------------
here is something wrong, the previous line already covers this range

================
Comment at: lib/tsan/rtl/tsan_platform.h:60
@@ +59,3 @@
+4000 0000 0000 - 4fff ffff ffff: high metainfo (memory blocks and sync objects)
+6000 0000 0000 - 6000 000f ffff: trace
+7d00 0000 0000 - 7dff ffff ffff: heap
----------------
what's at 5000 0000 0000 - 6000 0000 0000 ?

http://reviews.llvm.org/D5709






More information about the llvm-commits mailing list