[PATCH] Bug 21233 - Catch more cases in SLP vectorizer

[Sanjin Sijaric]

Hi Chad and Hal,

Thanks for catching this, Chad.  It was not intentional.  The new patch is attached.

Sanjin

-----Original Message-----
From: Hal Finkel [mailto:hfinkel at anl.gov] 
Sent: Wednesday, October 22, 2014 8:08 AM
To: mcrosier at codeaurora.org
Cc: llvm-commits at cs.uiuc.edu; Sanjin Sijaric; Andrew Trick; Arnold Schwaighofer
Subject: Re: [PATCH] Bug 21233 - Catch more cases in SLP vectorizer

----- Original Message -----
> From: "Chad Rosier" <mcrosier at codeaurora.org>
> To: "Sanjin Sijaric" <ssijaric at codeaurora.org>
> Cc: llvm-commits at cs.uiuc.edu
> Sent: Wednesday, October 22, 2014 9:57:36 AM
> Subject: Re: [PATCH] Bug 21233 - Catch more cases in SLP vectorizer
> 
> Hi Sanjin,
> 
> > The attached patch addresses bug #21233.  I didn't see a way to 
> > vectorize the attached test case without using SCEV-AA along with a 
> > small change in SLP vectorizer to retrieve the base pointer using 
> > SCEV analysis.
> 
> +      if (UseSCEVAAForSLP)
> +        MPM.add(createScalarEvolutionAliasAnalysisPass());
> +      MPM.add(createSLPVectorizerPass());   // Vectorize parallel
> scalar
> chains.
> 
> This looks to be add a call to the SLP vectorizer pass.  Is this 
> change indented?  I imagine you just want to add the SCEV-AA pass 
> before the existing SLP vectorizer pass a few lines above this change.
> 
> > Can someone please have a look?  Is it safe to use SCEV-AA, or 
> > should I pursue a different approach?
> 
> I'm not the right person to comment on the use of SCEV-AA in the SLP 
> vectorizer.  Perhaps, Arnold, Hal, or someone else could provide their 
> opinion.

We'd obviously not been using SCEV-AA because the current pass manager does not allow it to be preserved. As a result, I'm not sure how well tested it is (it is also pretty simple, so I'm not super concerned, only somewhat concerned). My thought has been that, once we have the new pass manager, we can do a cost-benefit analysis on using SCEV-AA more generally (especially since doing so might allow us to strip down BasicAA somewhat). I'm not opposed to gaining some more experience with SCEV-AA by using it in a targeted place like this.

Andy, do you have an opinion on this? Arnold?

 -Hal

> 
>  Chad
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

--
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PATCH
Type: application/octet-stream
Size: 4883 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141022/0509f87a/attachment.obj>