[PATCH] Add DarwinInputGraph

Michael Spencer bigcheesegs at gmail.com
Tue Oct 21 15:41:04 PDT 2014


On Mon, Oct 20, 2014 at 9:21 PM, Rui Ueyama <ruiu at google.com> wrote:
> I'm not still sure whether or not "InputGraph" thing was after all the right way to abstract the input file list. That often makes easy things hard. In this case, sorting a list of input files became that hard. When I proposed the idea I was thinking that would make this kind of things easier to handle. I don't think the current shape of the API is not desirable at least. Or the fundamental idea was not very good.
>
> One thing we probably should consider is, in my opinion, we are pushing too hard to separate all ports. We are trying to write any architecture-dependent code into architecture-specific file. But the natural border of API doesn't always fit to the architecture dependent/independent border. We should probably relax that constraint a bit where that makes sense and write code that's short and easier to understand.

I agree. The current InputGraph code makes modifying the input very
difficult to do. Part of the reason for the model in the first place
was to make this easy. I'm currently working on adding #pragma lib
like support for ELF (PS4 specific stuff) and have found it basically
impossible to add a new input file in the correct position in the
graph with the current model.

- Michael Spencer




More information about the llvm-commits mailing list