[PATCH] Support using sample profiles with partial debug info.

Diego Novillo dnovillo at google.com
Tue Oct 21 15:31:04 PDT 2014


On Tue, Oct 21, 2014 at 6:24 PM, David Blaikie <dblaikie at gmail.com> wrote:

> ================
> Comment at: lib/Transforms/Scalar/SampleProfile.cpp:647
> @@ -645,2 +646,3 @@
> +                                          const LLVMContext &Ctx) {
>    NamedMDNode *CUNodes = F.getParent()->getNamedMetadata("llvm.dbg.cu");
>    if (CUNodes) {
> ----------------
> Why do we need this code at all? Should we just remove it in favor of the
> other code?
>

I was actually going to ask you.  It seemed to me that this variant might
be slightly more efficient than the one that does not rely on llvm.dbg.cu?
(all the insn iteration, I mean).

If you don't  think that's the case, then it certainly is simpler if I just
remove it altogether.


Diego.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141021/bfcfb9bb/attachment.html>


More information about the llvm-commits mailing list