[PATCH] Add minnum / maxnum intrinsics
hfinkel at anl.gov
hfinkel at anl.gov
Tue Oct 21 15:09:13 PDT 2014
LGTM, thanks!
================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:551
@@ +550,3 @@
+ if (isa<UndefValue>(Arg1))
+ return ReplaceInstUsesWith(CI, Arg0);
+
----------------
I believe this to be correct, we cannot return undef because we're prohibited from making the output NaN (even if the input is NaN so long as both inputs are not NaN). But please add a comment explaining this.
http://reviews.llvm.org/D5716
More information about the llvm-commits
mailing list