[lld] r220185 - [ELF] Add demangle test to XFAIL

[Rui Ueyama]

No strong preference, but it seems XFAIL is tend to be forgotten. Compared
to that C++ files are maintained well. So if we can fix this in C++ with a
TODO, it's better to do that instead of adding a XFAIL to a failing test.

On Mon, Oct 20, 2014 at 1:33 PM, Shankar Easwaran <shankare at codeaurora.org>
wrote:

> On 10/20/2014 3:18 PM, Rui Ueyama wrote:
>
>> On Mon, Oct 20, 2014 at 12:56 PM, Ed Maste <emaste at freebsd.org> wrote:
>>
>>  On 20 October 2014 15:41, Rui Ueyama <ruiu at google.com> wrote:
>>>
>>>> So the machine is running FreeBSD 10.0-RELEASE-p7 amd64.
>>>>
>>> Yes, so it seems that the most recent release has the same issue with
>>> #include dependencies or something similar.
>>>
>>> We could try to work around it in CMake's check, or just wait and
>>> upgrade the buildbot to FreeBSD 10.1 when it's released (currently
>>> expected to be at the end of the month).
>>>
>>>  If FreeBSD is guaranteed to have the header file, I'm OK to add the
>> following code to the C++ file with a TODO to remove it after FreeBSD
>> 10.1.
>>
>> #if __FREEBSD__
>> #include <stddef.h>
>> #include <cxxabi.h>
>> #endif
>>
>>  Which C++ file are you talking about ? Are you saying #ifndef
> __FREEBSD__ ?
>
> I would leave the code as is and mark it with XFAIL since the fix later
> after the buildbot is fixed, will just be in the test
>
> Shankar Easwaran
>
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by the Linux Foundation
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141021/4c07fc18/attachment.html>