[PATCH] [Tsan] Fix the signal_recursive.cc test to build on FreeBSD
Viktor Kutuzov
vkutuzov at accesssoftek.com
Tue Oct 21 07:05:17 PDT 2014
================
Comment at: test/tsan/signal_recursive.cc:14-18
@@ -13,3 +13,7 @@
+#if defined(__FreeBSD__)
+static const int kSigSuspend = SIGINFO;
+#else
static const int kSigSuspend = SIGPWR;
+#endif
static const int kSigRestart = SIGXCPU;
----------------
emaste wrote:
> Is the specific signal of interest here, or do we just need two arbitrary signals? If the latter, can we just use `SIGUSR1` instead?
To me they look like two arbitrary "informative" signals that do not need any special handling. From this point of view, SIGINFO may be somewhat more expressive than SIGUSR1, but I'm not sure.
Dmitry, can you please let us know if SIGPWR and SIGXCPU have been chosen for a reason?
http://reviews.llvm.org/D5841
More information about the llvm-commits
mailing list