[PATCH] [Tsan] Fix the thread_name tests to build on FreeBSD

Dmitry Vyukov dvyukov at google.com
Tue Oct 21 00:28:42 PDT 2014


================
Comment at: lib/tsan/rtl/tsan_interface_ann.cc:423
@@ -422,1 +422,3 @@
 
+void INTERFACE_ATTRIBUTE AnnotateThreadNameByUserId(
+    uptr thread, char *f, int l, char *name) {
----------------
Please don't add new annotations. They are supported only for historical reasons. A test is definitely not a reason to add an annotation.

Emaste says there is pthread_set_name_np on freebsd; if it's so, use it in the test and intercept it in tsan_interceptors.cc. Otherwise disable the test on freebsd.
Or just disable the test on freebsd. Thread names is not critical functionality.

http://reviews.llvm.org/D5855






More information about the llvm-commits mailing list