[PATCH] Bug 20557 - bogus cpu parameter crashes llc

[Hao Liu]

Hi Oleg,

I'm very sorry that I missed this message for such a long time.

I think your solution is reasonable. But it looks somehow misleading. People don't know what is the current PreferredAction. So I think we'd better use more if and else as following:
      if (PreferredAction == TypeSplitVector)
        setTypeAction TypeSplitVector 
      else if (PreferredAction == TypeScalarizeVector)
         setTypeAction TypeScalarizeVector 
      else
         // when the preferred action is neither TypeSplitVector nor TypeScalarizeVector
        NElts == 1 ? TypeScalarizeVector : TypeSplitVector
I just think this is more clear.

Thanks,
-Hao

http://reviews.llvm.org/D5021