[PATCH] MCJIT honor symbol visibility settings when populating the global symbol table

Lang Hames lhames at gmail.com
Mon Oct 20 17:29:17 PDT 2014


Unfortunately this broke some of the bots. I'm going to temporarily revert
it while I try to track down the issue.

Cheers,
Lang.

On Mon, Oct 20, 2014 at 4:52 PM, Lang Hames <lhames at gmail.com> wrote:

> Looks good to me. Committed in r220245. Thanks very much for all your work
> on this Anthony!
>
> Thanks for the help with the review too Rafael.
>
> Cheers,
> Lang.
>
> On Mon, Oct 20, 2014 at 11:17 AM, Rafael EspĂ­ndola <
> rafael.espindola at gmail.com> wrote:
>
>> This patch looks good to me.
>>
>> Lang, can you commit if the MCJIT bits look good to you?
>>
>> On 20 October 2014 12:28, Anthony Pesch <inolen at gmail.com> wrote:
>> > I don't have commit access. Should I get that setup or can someone
>> > commit on my behalf?
>> >
>> > I've attached a patch without any spacing changes (sorry for the noise).
>> >
>> >  - Anthony
>> >
>> > On Mon, Oct 20, 2014 at 7:29 AM, Rafael EspĂ­ndola
>> > <rafael.espindola at gmail.com> wrote:
>> >> On 19 October 2014 18:16, Anthony Pesch <inolen at gmail.com> wrote:
>> >>> Hey guys,
>> >>>
>> >>> Alright, updated the patch, added isExportedToOtherDSO, updated
>> >>> comments, and converted the tests to spaces instead of tabs.
>> >>
>> >> The ELF bits looks good.
>> >>
>> >> Please commit the tabs to spaces change by itself before the rest of
>> >> the file. Do you have commit access?
>> >>
>> >> Cheers,
>> >> Rafael
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141020/226404f6/attachment.html>


More information about the llvm-commits mailing list