[PATCH] Fix optnone on Windows

Robinson, Paul Paul_Robinson at playstation.sony.com
Mon Oct 20 15:54:51 PDT 2014


[PATCH] Fix optnone on Windows

Normally an 'optnone' function goes through fast-isel, which does not
call DAGCombiner.  But we ran into a case (on Windows) where the
calling convention causes argument lowering to bail out of fast-isel,
and we end up in CodeGenAndEmitDAG() which does run DAGCombiner.
So, we need to make DAGCombiner check for 'optnone' after all.

Along the way we discovered we hadn't committed all the tests we had
written for 'optnone' so here are two more. 'fastmath-optnone.ll' is
the test that caught this, 'optnone-simple.ll' is one we missed from
our original implementation.
Thanks,
--paulr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: optnone-dag.patch
Type: application/octet-stream
Size: 5790 bytes
Desc: optnone-dag.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141020/83e3712f/attachment.obj>


More information about the llvm-commits mailing list