[PATCH] Refactor/simplify llvm-symbolizer code.
Alexey Samsonov
vonosmas at gmail.com
Mon Oct 20 15:07:02 PDT 2014
Hi glider,
This change rewrites significant part of llvm-symbolizer code,
as it has grown convoluted after a number of recent changes.
Most significantly, it simplifies ownership strategy: parsed binaries
and objects are now wrapped in OwningBinary<> or std::unique_ptr and
are always owned by LLVMSymbolizer object (so there's no need for explicit
destructor), and LLVMSymbolizer::loadObject / loadBinary methods
encapsulate calls to methods of LLVMObject and return raw pointers,
to objects owned by LLVMSymbolizer.
http://reviews.llvm.org/D5874
Files:
test/tools/llvm-symbolizer/errors.test
tools/llvm-symbolizer/LLVMSymbolize.cpp
tools/llvm-symbolizer/LLVMSymbolize.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5874.15154.patch
Type: text/x-patch
Size: 16092 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141020/fbe95ac7/attachment.bin>
More information about the llvm-commits
mailing list