[llvm] r219135 - [BasicAA] Revert "Revert r218714 - Make better use of zext and sign information."

[Hal Finkel]

----- Original Message -----
> From: "Nicholas White" <n.j.white at gmail.com>
> To: "Hal Finkel" <hfinkel at anl.gov>
> Cc: "Commit Messages and Patches for LLVM" <llvm-commits at cs.uiuc.edu>, "Lang Hames" <lhames at gmail.com>, "James
> Molloy" <James.Molloy at arm.com>, "Richard Barton" <richard.barton at arm.com>
> Sent: Monday, October 20, 2014 1:46:30 PM
> Subject: Re: [llvm] r219135 - [BasicAA] Revert "Revert r218714 - Make better use of zext and sign information."
> 
> 
> 
> > I don't understand. If AllPositive becomes false, then we don't
> > return NoAlias later; why does it matter if we do the remaining
> > checks -- AllPositive will remain false once it has been set to
> > false, right?
> 
> That's true - I just wanted to make sure that if anyone introduced
> more alias-guessing logic just before the final "return
> PartialAlias" they wouldn't introduce a subtle bug. I could just
> mention this in a comment there though? Thanks -

Yes, please. Thanks!

 -Hal

> 
> Nick
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory