[lld] r220182 - [ELF] Check for target architecture.
Renato Golin
renato.golin at linaro.org
Mon Oct 20 04:50:11 PDT 2014
On 20 October 2014 12:40, Shankar Easwaram <shankarke at gmail.com> wrote:
> I agree that it would be simpler to add all the functionality in the parent class which is the ELFObjectReader, but i think it's much cleaner and flexible with each elf subtarget own what all in the elf header to check.
Moving the generic part to a parent class doesn't preclude you from
adding extra bits on the children.
For instance:
if (ARM.specificStuff())
return ARM.specificTest();
return ELFObjectReader::canParse(...);
cheers,
--renato
More information about the llvm-commits
mailing list