[lld] r220182 - [ELF] Check for target architecture.

Renato Golin renato.golin at linaro.org
Mon Oct 20 01:41:04 PDT 2014


On 20 October 2014 05:00, Shankar Easwaran <shankarke at gmail.com> wrote:
> The canParse function for all the ELF subtargets check if the input files match
> the subtarget.

Hi Shankar,

I'm new at the lld code, but it seems like a whole lot of repetition
for such a simple method. If you could cache the arch definitions
locally, this could be a single method on the parent of those classes,
comparing to the "static const Arch" or equivalent, no?

cheers,
--renato



More information about the llvm-commits mailing list