[PATCH] Initial version of Go bindings.
Chandler Carruth
chandlerc at gmail.com
Thu Oct 16 11:51:05 PDT 2014
I think with the C interface naming tweaks and some other minor stuff this is ready to go in.
If you'd like me to take another look at anything, let me know, otherwise feel free to commit once you've addressed the comments (or refuted them as wrong headed!).
Thanks!
================
Comment at: bindings/go/llvm/ir.go:1
@@ +1,2 @@
+//===- ir.go - Bindings for ir --------------------------------------------===//
+//
----------------
I know its pedantic, but could you capitalize 'IR' when using it as a normal noun in a sentence? (Clearly the Go APIs and files need to remain lower case, just talking about the comments.)
================
Comment at: bindings/go/llvm/target.go:210
@@ +209,3 @@
+
+///////////////////////////////////////////////////////////////////////////////
+// Target
----------------
nit: There seem to be a mixture of horizontal rule comment styles... I would pick on and be consistent with it.
But maybe there is some Go style thing going on here that I'm just not aware of. If so, ignore me. =]
http://reviews.llvm.org/D5684
More information about the llvm-commits
mailing list