[PATCH] Do not split variables definitions into 2 DIEs.

Frédéric Riss friss at apple.com
Thu Oct 16 08:46:25 PDT 2014


ping

> On 09 Oct 2014, at 16:19, Frederic Riss <friss at apple.com> wrote:
> 
> I finally managed to get some test results for this patch. Indeed putting the static member variable definition broke some lldb tests, thus I left the behavior unchanged for static member variables. This is still a nice cleanup of the global variable DIE creation logic.
> 
> David, if you still like the direction I'd appreciate if you could give it a test run on the GDB testsuite to see if it doesn't break anything there. Note that I haven't included an additional test for type units as I removed the behavior change that might have caused issues with that usecase.
> 
> http://reviews.llvm.org/D5457
> 
> Files:
>  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
>  test/DebugInfo/X86/gnu-public-names.ll
> <D5457.14686.patch>





More information about the llvm-commits mailing list