[llvm] r219837 - Wrong attribute. LLVM_ATTRIBUTE_USED not LLVM_ATTRIBUTE_UNUSED

[Benjamin Kramer]

On 15.10.2014, at 21:32, Sid Manning <sidneym at codeaurora.org> wrote:

> Author: sidneym
> Date: Wed Oct 15 14:32:52 2014
> New Revision: 219837
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=219837&view=rev
> Log:
> Wrong attribute. LLVM_ATTRIBUTE_USED not LLVM_ATTRIBUTE_UNUSED

LLVM_ATTRIBUTE_UNUSED was the right attribute. LLVM_ATTRIBUTE_USED means "always emit this into the object file", that's not what we want here. LLVM_ATTRIBUTE_UNUSED just disables 'unused function' warnings.

- Ben
> 
> Modified:
>    llvm/trunk/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp
> 
> Modified: llvm/trunk/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp?rev=219837&r1=219836&r2=219837&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp Wed Oct 15 14:32:52 2014
> @@ -63,7 +63,7 @@ static bool isExtended(uint64_t TSFlags)
> }
> 
> // Currently just used in an assert statement
> -static bool isExtendable(uint64_t TSFlags) LLVM_ATTRIBUTE_UNUSED;
> +static bool isExtendable(uint64_t TSFlags) LLVM_ATTRIBUTE_USED;
> // Return true if the instruction may be extended based on the operand value.
> static bool isExtendable(uint64_t TSFlags) {
>   return (TSFlags >> HexagonII::ExtendablePos) & HexagonII::ExtendableMask;
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits