[PATCH] Reduce code duplication between patchpoint and non-patchpoint lowering. NFC.

Juergen Ributzka juergen at apple.com
Wed Oct 15 10:35:58 PDT 2014


LGTM

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7047
@@ -7034,3 +7046,3 @@
 
   // Set the root to the target-lowered call chain.
   SDValue Chain = Result.second;
----------------
Comment is now out-of-date.

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h:24
@@ -23,2 +23,3 @@
 #include "llvm/Support/ErrorHandling.h"
+#include "llvm/Target/TargetLowering.h"
 #include <vector>
----------------
No need to include the header. A forward declaration of the class should be enough.

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h:648-650
@@ -646,1 +647,5 @@
 private:
+  std::pair<SDValue, SDValue> LowerInvokable(
+          TargetLowering::CallLoweringInfo &CLI,
+          MachineBasicBlock *LandingPad);
+
----------------
I know the coding standard in this file is a little messy, but new functions should be added in camelCase.

http://reviews.llvm.org/D5657






More information about the llvm-commits mailing list