[PATCH] [MC] Make bundle alignment mode setting idempotent and support nested bundles
Eli Bendersky
eliben at google.com
Wed Oct 15 09:44:29 PDT 2014
LGTM, with a couple of nits
================
Comment at: lib/MC/MCAssembler.cpp:338
@@ +337,3 @@
+ }
+ if(--BundleLockNestingDepth == 0) {
+ BundleLockState = NotBundleLocked;
----------------
if (
================
Comment at: lib/MC/MCAssembler.cpp:346
@@ +345,3 @@
+ // group is align_to_end. So don't downgrade from align_to_end to just locked.
+ if (BundleLockState != BundleLockedAlignToEnd)
+ BundleLockState = NewState;
----------------
Can you put {...} around the contents, for consistency with other code in this method?
================
Comment at: lib/MC/MCELFStreamer.cpp:481
@@ -478,2 +480,3 @@
+ Assembler.getBundleAlignSize() == 1U << AlignPow2))
Assembler.setBundleAlignSize(1 << AlignPow2);
else
----------------
s/1/1U/ for consistency with above?
http://reviews.llvm.org/D5801
More information about the llvm-commits
mailing list