[llvm] r217909 - [llvm-objdump] improve error reporting of bad mach-o ordinals

Nick Kledzik kledzik at apple.com
Tue Oct 14 17:43:06 PDT 2014


On Oct 14, 2014, at 10:15 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:

>> I don’t know how to create a test file with bad ordinals in order to create a test case for the error handling changes…
> 
> In the past I have just used hexedit to patch in an invalid number in a .o.
> 
> Making sure error paths are tested is important to make sure we don't
> end up with bogus error handling like the one removed in r219314 and
> to make it safe to refactor the error handling in the future.

I checked in a bad binary and a test case in r219746.

-Nick



More information about the llvm-commits mailing list