[PATCH] Introduce Go coding standards for LLVM.

Chandler Carruth chandlerc at gmail.com
Mon Oct 13 15:58:29 PDT 2014


I think this is fine. I'd like to see Reid's comments addressed, but I don't think this patch is really a step backwards in any sense.

================
Comment at: docs/CodingStandards.rst:182-184
@@ +181,5 @@
+
+Any code written in the Go programming language is not subject to the
+formatting rules below. Instead, we adopt the formatting rules enforced by
+the `gofmt`_ tool.
+
----------------
rnk wrote:
> We should probably just say that none of these conventions apply to non-C-family languages. Our Python bindings and lit are basically PEP8 style, for example.
I'm fine with clarifying that in a further patch if you want, but I also think its totally fine for us to actually state that Go code, if it exists in LLVM, should follow the gofmt and idiomatic patterns documented by the Go folks.

http://reviews.llvm.org/D5761






More information about the llvm-commits mailing list